Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtime sample code update #417

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Gtime sample code update #417

merged 2 commits into from
Mar 4, 2020

Conversation

greggTime
Copy link
Contributor

Summary

Changing payload to body in EN and JA examples. This will work with both commands and other events so it will be applicable in more cases. It will also cut down on some confusion around trying to look for trigger id in the payload object when dealing with block actions.

@greggTime greggTime requested a review from shaydewael March 4, 2020 20:30
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #417   +/-   ##
======================================
  Coverage    81.5%   81.5%           
======================================
  Files           7       7           
  Lines         530     530           
  Branches      152     152           
======================================
  Hits          432     432           
  Misses         70      70           
  Partials       28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217fe72...2133625. Read the comment docs.

@seratch
Copy link
Member

seratch commented Mar 4, 2020

@greggTime Thanks for taking the time to improve the docs. It looks good to me!
Could you sign our CLA? https://cla-assistant.io/slackapi/bolt?pullRequest=417

@seratch seratch added the docs M-T: Documentation work only label Mar 4, 2020
@seratch seratch self-assigned this Mar 4, 2020
@seratch seratch merged commit e21b237 into master Mar 4, 2020
@seratch
Copy link
Member

seratch commented Mar 5, 2020

Thanks for your contribution! I'll make a PR for the @slack/bolt@next branch later.

seratch added a commit to seratch/bolt-js that referenced this pull request Mar 5, 2020
stevengill added a commit that referenced this pull request Mar 5, 2020
[v2] Bring PR #417 changes to v2 branch
@seratch seratch deleted the gtime_sample_code_update branch June 1, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants