Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Bring PR #417 changes to v2 branch #418

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 5, 2020

Summary

This pull request brings the changes by #417 (thanks @greggTime !) to the v2 branch. It had some conflicts so that I came up with a plain commit.

Requirements (place an x in each [ ])

@seratch seratch added docs M-T: Documentation work only semver:major labels Mar 5, 2020
@seratch seratch added this to the V2 milestone Mar 5, 2020
@seratch seratch self-assigned this Mar 5, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #418 into @slack/bolt@next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           @slack/bolt@next     #418   +/-   ##
=================================================
  Coverage             85.51%   85.51%           
=================================================
  Files                     7        7           
  Lines                   511      511           
  Branches                146      146           
=================================================
  Hits                    437      437           
  Misses                   49       49           
  Partials                 25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1428ec3...8aa5727. Read the comment docs.

@stevengill stevengill merged commit 711d3bd into slackapi:@slack/bolt@next Mar 5, 2020
@seratch seratch deleted the pr-417 branch March 5, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only semver:major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants