We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Logger instance given to WebClient is destructively modified with a static name "WebClient" and also given logLevel.
Logger
WebClient
"WebClient"
logLevel
This particularly affects Bolt apps. The name of all the logs generated by Bolt apps is forcibly set as WebClient:{instanceId}.
WebClient:{instanceId}
I'll come up with a pull request suggesting a possible solution to address this issue.
x
[ ]
Filling out the following details about bugs will help us solve your issue sooner.
Select all that apply:
@slack/web-api
@slack/events-api
@slack/interactive-messages
@slack/rtm-api
@slack/webhooks
package version: all node version: any OS version(s): any
A Bolt app as below reproduces the issue.
const { App } = require('@slack/bolt'); const { ConsoleLogger, LogLevel } = require('@slack/logger'); const logger = new ConsoleLogger(); const app = new App({ logger: logger, token: process.env.SLACK_BOT_TOKEN, signingSecret: process.env.SLACK_SIGNING_SECRET });
Already stated in the description.
None.
The text was updated successfully, but these errors were encountered:
Fix slackapi#916 Logger given to WebClient is destructively modified
e68a7e1
Merge pull request #917 from seratch/avoid-destructive-op-to-logger
95a5618
Fix #916 Logger given to WebClient is destructively modified
seratch
Successfully merging a pull request may close this issue.
Description
The
Logger
instance given toWebClient
is destructively modified with a static name"WebClient"
and also givenlogLevel
.This particularly affects Bolt apps. The name of all the logs generated by Bolt apps is forcibly set as
WebClient:{instanceId}
.I'll come up with a pull request suggesting a possible solution to address this issue.
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Packages:
Select all that apply:
@slack/web-api
@slack/events-api
@slack/interactive-messages
@slack/rtm-api
@slack/webhooks
Reproducible in:
package version: all
node version: any
OS version(s): any
Steps to reproduce:
A Bolt app as below reproduces the issue.
Expected result:
Already stated in the description.
Actual result:
Already stated in the description.
Attachments:
None.
The text was updated successfully, but these errors were encountered: