Fix #916 Logger given to WebClient is destructively modified #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
==========================================
- Coverage 95.17% 94.92% -0.25%
==========================================
Files 12 12
Lines 725 729 +4
Branches 164 166 +2
==========================================
+ Hits 690 692 +2
Misses 13 13
- Partials 22 24 +2
Continue to review full report at Codecov.
|
stevengill
approved these changes
Nov 27, 2019
| if (typeof logger !== 'undefined') { | ||
| this.logger = logger; | ||
| if (typeof logLevel !== 'undefined') { | ||
| this.logger.debug('The logLevel given to WebClient was ignored as you also gave logger'); |
There was a problem hiding this comment.
So the loglevel parameter is useless in this instance because by passing in logger, it is assumed it already has a loglevel set
|
Thanks for your review. I don't think this is an urgent one but it'll be great if we could have a new release of both |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #916. Refer to the issue for details.
Requirements (place an
xin each[ ])