Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings to channels/groups/mpim/im API method calls #650

Closed
5 of 9 tasks
seratch opened this issue Apr 14, 2020 · 2 comments
Closed
5 of 9 tasks

Deprecation warnings to channels/groups/mpim/im API method calls #650

seratch opened this issue Apr 14, 2020 · 2 comments
Assignees
@seratch
Labels
docs M-T: Documentation work only enhancement M-T: A feature request for new functionality Version: 2x web-client
Milestone
2.6.0

Comments

@seratch
Copy link
Member

seratch commented Apr 14, 2020

Description

As with slackapi/node-slack-sdk#992, slackclient should show warnings to those method calls.

https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added Version: 2x enhancement M-T: A feature request for new functionality docs M-T: Documentation work only web-client labels Apr 14, 2020
@seratch seratch added this to the 2.6.0 milestone Apr 20, 2020
seratch added a commit to seratch/python-slack-sdk that referenced this issue Apr 28, 2020
@seratch
Fix slackapi#650 Deprecation warnings to channels/groups/mpim/im API …
40ae3b1 
…method calls
@seratch seratch assigned seratch and unassigned stevengill Apr 28, 2020
@seratch
Copy link
Member Author

seratch commented Apr 28, 2020 •
edited
Loading

@stevengill I've changed the internals of WebClient a lot in #662 . So, let me take over this task. I've pushed a commit addressing this - seratch@40ae3b1

Let me know in the pull request if you have comments.

@seratch seratch mentioned this issue Apr 28, 2020
Merged
2 tasks
seratch added a commit to seratch/python-slack-sdk that referenced this issue Apr 28, 2020
@seratch
Fix slackapi#650 Deprecation warnings to channels/groups/mpim/im API …
13bff49 
…method calls
@seratch seratch mentioned this issue Apr 28, 2020
Closed
9 tasks
seratch added a commit to seratch/python-slack-sdk that referenced this issue Apr 30, 2020
@seratch
Fix slackapi#650 Deprecation warnings to channels/groups/mpim/im API …
5cde3e2 
…method calls
@stevengill
Copy link
Member

Looks good Kaz

seratch added a commit to seratch/python-slack-sdk that referenced this issue May 11, 2020
@seratch
Fix slackapi#650 Deprecation warnings to channels/groups/mpim/im API …
11d4648 
…method calls
seratch added a commit to seratch/python-slack-sdk that referenced this issue May 11, 2020
@seratch
Fix slackapi#650 Deprecation warnings to channels/groups/mpim/im API …
8567730 
…method calls
seratch added a commit to seratch/python-slack-sdk that referenced this issue May 11, 2020
@seratch
Fix slackapi#650 Deprecation warnings to channels/groups/mpim/im API …
17c77c0 
…method calls
@seratch seratch mentioned this issue May 11, 2020
Merged
2 tasks
seratch added a commit that referenced this issue May 11, 2020
@seratch
Merge pull request #680 from seratch/issue-650
32ec88e 
Fix #650 Deprecation warnings to channels/groups/mpim/im API method calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
docs M-T: Documentation work only enhancement M-T: A feature request for new functionality Version: 2x web-client
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
2 participants
@seratch @stevengill