Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #650 Deprecation warnings to channels/groups/mpim/im API method calls #680

Merged
merged 1 commit into from
May 11, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 11, 2020

Summary

This pull request adds the warnings telling API deprecations. #650

I've extracted this change from PR #662 . And the change already has been reviewed by @stevengill so that let me merge this PR.
#650 (comment)

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #680 into master will decrease coverage by 0.27%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
- Coverage   87.13%   86.86%   -0.28%     
==========================================
  Files          15       16       +1     
  Lines        1842     1857      +15     
  Branches      110      114       +4     
==========================================
+ Hits         1605     1613       +8     
- Misses        203      209       +6     
- Partials       34       35       +1     
Impacted Files Coverage Δ
slack/web/__init__.py 46.15% <46.15%> (ø)
slack/web/base_client.py 81.19% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac471e...e4561fa. Read the comment docs.

@seratch seratch merged commit 32ec88e into slackapi:master May 11, 2020
@seratch seratch deleted the issue-650 branch May 11, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant