Fix #1428 Add rich_text classes to slack_sdk.models module #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
==========================================
- Coverage 85.46% 85.43% -0.04%
==========================================
Files 111 111
Lines 11945 12114 +169
==========================================
+ Hits 10209 10349 +140
- Misses 1736 1765 +29 ☔ View full report in Codecov by Sentry. |
|
🔥🙏🏼🎉 |
tj-smith47
reviewed
Nov 22, 2023
| @@ -604,3 +604,34 @@ def _validate_title_length(self): | |||
| @JsonValidator(f"author_name attribute cannot exceed {author_name_max_length} characters") | |||
| def _validate_author_name_length(self): | |||
| return self.author_name is None or len(self.author_name) < self.author_name_max_length | |||
|
|
|||
|
|
|||
| class RichTextBlock(Block): | |||
There was a problem hiding this comment.
I'm still having an issue with the parsing of this block. Looks like it needs to be added here.
There was a problem hiding this comment.
@tj-smith47 Thanks for pointing this out. Here is a PR to fix it: #1433 We will release a new version shortly
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #1428
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.