Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove value from LinkButtonElement #563

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Remove value from LinkButtonElement #563

merged 1 commit into from
Nov 21, 2019

Conversation

pedromcaraujo
Copy link
Contributor

Summary

Fixes #562

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #563 into master will increase coverage by 0.03%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   68.81%   68.84%   +0.03%     
==========================================
  Files          15       15              
  Lines        1725     1730       +5     
  Branches       98       99       +1     
==========================================
+ Hits         1187     1191       +4     
  Misses        512      512              
- Partials       26       27       +1
Impacted Files Coverage Δ
slack/web/classes/elements.py 85.39% <80%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687695b...d69276b. Read the comment docs.

@pedromcaraujo pedromcaraujo mentioned this pull request Nov 18, 2019
2 tasks
@RodneyU215 RodneyU215 added Priority: Medium bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x labels Nov 21, 2019
@RodneyU215
Copy link
Contributor

Thank you @pedroma! For reporting the issue and even more so for submitting a PR to fix it. 🙇

@RodneyU215 RodneyU215 merged commit 17b6abd into slackapi:master Nov 21, 2019
@pedromcaraujo
Copy link
Contributor Author

pedromcaraujo commented Nov 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid value property set on LinkButtonElement
3 participants