Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADS1217 ADC #1175

Draft
wants to merge 4 commits into
base: pre-release
Choose a base branch
from
Draft

Create ADS1217 ADC #1175

wants to merge 4 commits into from

Conversation

hsandber
Copy link
Contributor

@hsandber hsandber commented Jul 8, 2024

Description

Created ADS1217 ADC VHDL module and with matching Python class.

Details

Created a new AxiAds1217Core VHDL module with AXI4-Lite register access to ADC data for all channels.
This is a generalized version of modules that have been used in various projects, see for example:

JIRA

Related

@hsandber hsandber self-assigned this Jul 8, 2024
@hsandber
Copy link
Contributor Author

This ADC module only has AXI4-Lite access to the ADC data right now. In some previous applications there has been an AXI4-Stream interface also, which has not been implemented in this generic version of the module yet.

@ruck314, would you prefer to wait until a final version is available with both Lite and Stream interface, or would it better to get this "simpler" version merged in now? I do not have a time estimate for when the final version could be ready.

@ruck314
Copy link
Contributor

ruck314 commented Jul 11, 2024

@ruck314, would you prefer to wait until a final version is available with both Lite and Stream interface, or would it better to get this "simpler" version merged in now? I do not have a time estimate for when the final version could be ready.

@bengineerd Do you want to wait for the stream version of this?

@ruck314 ruck314 requested a review from bengineerd July 11, 2024 22:29
Copy link
Contributor

@bengineerd bengineerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsandber hsandber AxiAds1217Core.vhd does not follow the "two process" coding style for the sysClk registers.

@ruck314 ruck314 requested a review from bengineerd July 22, 2024 16:16
@hsandber
Copy link
Contributor Author

hsandber commented Jul 22, 2024

@bengineerd Do you prefer we close this pull request and delete the branch and then come back at "some point in the future" when the module has been rewritten to match the firmware standards for surf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants