Release Candidate v2.49.0 #1171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding rssi_network_analyzer.py
Create AD5541 DAC
Found C system header after other header. Should be: ssi_printf.h, c system, c++ system, other. [build/include_order]
Disable the build/header_guard check
Disable the readability/casting check
Tab found; better to use spaces [whitespace/tab]
Extra space before ( in function call [whitespace/parens]
…d obsolete to axi/simlink/src/VhpiGeneric.c/.h
Weird number of spaces at line-start. [whitespace/indent]
Missing space after , [whitespace/comma]
Disable the build/include_subdir check
At least two spaces is best between code and comments [whitespace/comments]
Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line]
Missing spaces around XXX operator [whitespace/operators]
If an else has a brace on one side, it should have it on both [readability/braces]
'time.h' already included at ./axi/simlink/src/RogueTcpStream.c:13 [build/include]
'time.h' already included at ./axi/simlink/src/RogueTcpStream.c:13 [whitespace/braces]
Could not find a newline character at the end of the file. [whitespace/ending_newline]
Else clause should never be on same line as else (use 2 lines) [whitespace/newline]
Semicolon defining empty statement. Use {} instead. [whitespace/semicolon]
Use int16/int64/etc, rather than the C type long [runtime/int]
Almost always, snprintf is better than strcpy [runtime/printf]
Never use sprintf. Use snprintf instead. [runtime/printf]
Weird number of spaces at line-start. [whitespace/indent]
bug fix for SsiPrbsRx.WordRate
General C/C++ Updates
…EQ_G ### Description - AXIS_CLK_FREQ_G is misleading name because generic is associated with the xvcClk (not axisClk) at surf.UdpDebugBridgeWrapper - Renaming this generic to XVC_CLK_FREQ_G
…le-10GbE-RUDP-KCU105-Example
Update DmaXvcWrapper.vhd
Update PgpXvcWrapper.vhd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description