Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AxiVersion.py Update #1180

Closed
wants to merge 1 commit into from
Closed

AxiVersion.py Update #1180

wants to merge 1 commit into from

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Jul 23, 2024

Description

  • adding warning message when Dirty Githash is detected

@ruck314 ruck314 requested a review from bengineerd July 23, 2024 21:36
@ruck314 ruck314 mentioned this pull request Jul 24, 2024
Merged
bengineerd
bengineerd reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@bengineerd bengineerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be careful with this. It creates an automatic read upon software startup, which a user might not want.

@ruck314
Copy link
Contributor Author

ruck314 commented Aug 12, 2024

@bengineerd What would you recommend doing instead?

@bengineerd
Copy link
Contributor

There's probably a way to detect the first read of the register and check it then.
I need to think about how that would work. It's up to you whether to merge this now or wait for that fix.

@ruck314 ruck314 closed this Sep 6, 2024
@ruck314 ruck314 deleted the AxiVersion-dirty-warning branch September 6, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengineerd bengineerd bengineerd left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruck314 @bengineerd