Improve typehinting for RouteParserInterface
#3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous typehinting (by docblock) was not sufficient, it only defined the value of the array. However, both `$data` as `$queryParams` are arrays where the key as well as value is a string. By improving the typehinting for these values, e.g. static analysis tools will recognize this.
…-parser-interface
|
Thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous typehinting (by docblock) in
RouteParserInterfacewas not sufficient, it only defined the value of the array. However, both$dataas$queryParamsare arrays where the key as well as value is a string.By improving the typehinting for these values, e.g. static analysis tools will recognize this instead of failing due to type mismatch.
Changes
$dataand$queryParamsinRouteParserInterfaceLinks