Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typehinting for RouteParserInterface #3133

Merged
merged 2 commits into from
Jan 2, 2022
Merged

Improve typehinting for RouteParserInterface #3133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce77d03
Improve typehinting for RouteParserInterface
jerowork Dec 31, 2021
303e0ed
Merge branch '4.x' into improvement/update-docblock-typehinting-route…
l0gicgate Jan 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Slim/Interfaces/RouteParserInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ interface RouteParserInterface
/**
* Build the path for a named route excluding the base path
*
* @param string $routeName Route name
* @param string[] $data Named argument replacement data
* @param string[] $queryParams Optional query string parameters
* @param string $routeName Route name
* @param array<string, string> $data Named argument replacement data
* @param array<string, string> $queryParams Optional query string parameters
*
* @return string
*
Expand All @@ -33,9 +33,9 @@ public function relativeUrlFor(string $routeName, array $data = [], array $query
/**
* Build the path for a named route including the base path
*
* @param string $routeName Route name
* @param string[] $data Named argument replacement data
* @param string[] $queryParams Optional query string parameters
* @param string $routeName Route name
* @param array<string, string> $data Named argument replacement data
* @param array<string, string> $queryParams Optional query string parameters
*
* @return string
*
Expand All @@ -47,10 +47,10 @@ public function urlFor(string $routeName, array $data = [], array $queryParams =
/**
* Get fully qualified URL for named route
*
* @param UriInterface $uri
* @param string $routeName Route name
* @param string[] $data Named argument replacement data
* @param string[] $queryParams Optional query string parameters
* @param UriInterface $uri
* @param string $routeName Route name
* @param array<string, string> $data Named argument replacement data
* @param array<string, string> $queryParams Optional query string parameters
*
* @return string
*/
Expand Down