Skip to content

Commit

Permalink
# This is a combination of 10 commits.
Browse files Browse the repository at this point in the history
# This is the 1st commit message:

# This is a combination of 15 commits.
# This is the 1st commit message:

fix some code according to PR review comments

change some format to pass TSlint check

add '_' before private elements

delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable

refine code

encapsulate 'set style for element'

change @input()

Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'

add const STICK_START_CLASS and STICK_END_CLASS

Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.

encapsulate reset css style operation for sticky header.

delete unnecessary gloable variables

delete global variable '_width'

Add doc for 'sticker()' function. explained how it works.

add more doc for 'sticker()', explaining 'isStuck' flag

2 space for indent

fix

delete sticky-header demo part from this branch

revert firebase file

change code according to comments in PR

revert firbaserc

revert routes.ts

change

fix the problem of : 'this.stickyParent' might be 'null'

change doc

Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'

Added prefix 'mat-' for CSS class

Delete 'public' before variables

Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.

 IE11 will have trouble with  `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'

Added docs for all variables

extract 'generate CSS style'

created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.

reformat

add debounce to solve 'getBoundingClientRect() cause slow down' problem.

add position:sticky and check whether browser support it. If not , use the naive implementation

removed unused import

Removed unused 'scrollableRegion' and 'parentRegion'

removed commented lines

default public

Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function

format

consider all circumstances of browser.

use "===" instead of '=='

 make 'navigator.userAgent.toLocaleLowerCase()' a local variable

optimize

Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end

Added comments for STICK_START_CLASS and STICK_END_CLASS.

Changed the format of one-line JsDoc

unsubscribe sbscriptions onDestory

Use what modernizr does on compatibility instead of get the browser version directly.

add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).

move docs above @directive

removed the underscore in'_element: ElementRef',

expand 'reg' to 'region'

use 'if (this.isIE)' instead of 'if(this.isIE === true)'

added more newlines between params in 'generateCssStyle()' function to make it easier to understand.

Added reference link to Modernizer in docs of getSupportList()

Deleted "_supportList" variable

renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable

Set debounce time as a const variable

Added docs for 'const DEBOUNCE_TIME: number = 5;'

Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'

 Removed the @param and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function

Added docs for `isStickyPositionSupported` variable

changed '+=' to '=' of 'stickyText' in getSupportList() function

nit added " " between 'if' and '('

nit

Added comments

deleted unused import

change comments

optimize comments

deleted unnecessary global variables(padding and stickyRegionHeight)

Added check whether we are on browser

Array<string> to string[]

test?

try to reopen the old PR

fix after rebase

revert list.ts

test

test 222

revert demo

revert list.ts second time

Move code to 'src/cdk'

revert 'move code to 'src/cdk'' , it should be done in a new PR

revert

avoid calling 'getComputedStyle()' too many times.

rename as sticky-header.ts

# This is the commit message angular#2:

imported PlatformModule
# This is the commit message angular#3:

Add blank lines between these top-level symbol
# This is the commit message angular#4:

make '_isStickyPositionSupported' private
# This is the commit message angular#5:

Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
# This is the commit message angular#6:

Rename '_containerStart' to '_stickyRegionTop'
# This is the commit message angular#7:

rename
# This is the commit message angular#8:

optimize discription for '_stickyRegionBottomThreshold'
# This is the commit message angular#9:

private _originalStyles = {
      position: '',
      top: '',
      right: '',
      left: '',
      bottom: '',
      width:  '',
      zIndex: ''};
# This is the commit message angular#10:

Deleted 'generateCssStyle()' and 'getCssNumber()' function
# This is the commit message angular#11:

Deleted 'getCssValue()' function
# This is the commit message angular#12:

fix CSSStyleDeclaration


# This is the commit message angular#13:

change sticky width to 'this.upperScrollableContainer.clientWidth'
# This is the commit message angular#14:

fix
# This is the commit message angular#15:

nit
# This is the commit message angular#2:

Added the 'isPositionStickySupported() ' function  to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
# This is the commit message angular#3:

nit


# This is the commit message angular#4:

nit
# This is the commit message angular#5:

update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
# This is the commit message angular#6:

changed the doc to  '/** z-index to be applied to the sticky header (default is 10). */'
# This is the commit message angular#7:

fix tslint error
# This is the commit message angular#8:

for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'


# This is the commit message angular#9:

Deleted variable 'elemHeight'
# This is the commit message angular#10:

Chaned to 'if (!this.stickyParent)'
  • Loading branch information
sllethe committed Aug 1, 2017
1 parent f614f83 commit a33e343
Show file tree
Hide file tree
Showing 6 changed files with 374 additions and 367 deletions.
5 changes: 0 additions & 5 deletions .firebaserc

This file was deleted.

1 change: 0 additions & 1 deletion src/demo-app/demo-app-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ import {
} from '@angular/material';
import {CdkTableModule} from '@angular/cdk';
import {TableHeaderDemo} from './table/table-header-demo';
import {StickyHeaderDemo} from './sticky-header/sticky-header-demo';

/**
* NgModule that includes all Material modules that are required to serve the demo-app.
Expand Down
2 changes: 0 additions & 2 deletions src/demo-app/demo-app/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ import {DatepickerDemo} from '../datepicker/datepicker-demo';
import {TableDemo} from '../table/table-demo';
import {TypographyDemo} from '../typography/typography-demo';
import {ExpansionDemo} from '../expansion/expansion-demo';
import {StickyHeaderDemo} from '../sticky-header/sticky-header-demo';


export const DEMO_APP_ROUTES: Routes = [
{path: '', component: Home},
Expand Down
298 changes: 0 additions & 298 deletions src/lib/sticky-header/sticky-header-dir.ts

This file was deleted.

Loading

0 comments on commit a33e343

Please sign in to comment.