Add struct and functionality for using user input #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbehjati
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
laurentsimon
approved these changes
Dec 15, 2022
ianlewis
approved these changes
Dec 16, 2022
rbehjati
force-pushed
the
builder-3
branch
2 times, most recently
from
8029375
to
088ccd9
Compare
rbehjati
force-pushed
the
builder-3
branch
4 times, most recently
from
9db3d71
to
6ab04cb
Compare
rbehjati
commented
Dec 20, 2022
|
|
||
| // NewDockerBuildConfig validates the inputs and generates an instance of | ||
| // DockerBuildConfig. | ||
| func NewDockerBuildConfig(io *InputOptions) (*DockerBuildConfig, error) { |
|
@asraa @laurentsimon @ianlewis I am happy with this PR. Can you please merge it? |
|
Can you rebase and solve the conflicts? |
Signed-off-by: Razieh Behjati <razieh@google.com>
Signed-off-by: Razieh Behjati <razieh@google.com>
auto-merge was automatically disabled
December 21, 2022 17:23
Head branch was pushed to by a user without write access
Done. But now the CI step for |
|
Many thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1191
Builds on top of #1386 and adds struct and functionality for parsing and using user-provided input.
Moves
InputOptionsto packagepkgto be able to pass it as an argument toNewDockerBuildConfigwithout introducing a circular dependency.