Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write subjects to file in docker-based builder binary #1481

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

rbehjati
Copy link
Contributor

@rbehjati rbehjati commented Jan 9, 2023

Fixes #1191

Signed-off-by: Razieh Behjati razieh@google.com

internal/builders/docker/commands.go Outdated Show resolved Hide resolved
internal/builders/docker/commands.go Outdated Show resolved Hide resolved
Signed-off-by: Razieh Behjati <razieh@google.com>
Signed-off-by: Razieh Behjati <razieh@google.com>
Copy link
Contributor Author

@rbehjati rbehjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews.

internal/builders/docker/commands.go Outdated Show resolved Hide resolved
internal/builders/docker/commands.go Outdated Show resolved Hide resolved
internal/builders/docker/commands.go Outdated Show resolved Hide resolved
@asraa asraa changed the title Write subjects to file feat: write subjects to file in docker-based builder binary Jan 10, 2023
@asraa asraa merged commit 2a94850 into slsa-framework:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Create a docker-based builder binary that executes a builder image to produce a binary
4 participants