golangci-lint cleanup #10312
Merged
golangci-lint cleanup #10312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineffectual assignment (ineffassign) unused (unused) receiver-naming: receiver name should not be an underscore, omit the name if it is unused (revive) unreachable: unreachable code (govet) rows.Err must be checked (rowserrcheck)
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
requested review from
a team,
connorwstein,
reductionista,
samsondav and
prashantkumar1982
as code owners
jmank88
requested review from
a team
and removed request for
a team,
reductionista,
samsondav,
connorwstein and
prashantkumar1982
|
SonarQube Quality Gate
|
ilija42
approved these changes
Aug 23, 2023
krehermann
approved these changes
Aug 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool-literal-in-expr: omit Boolean literal in expression (revive)
ineffectual assignment (ineffassign)
unused (unused)
receiver-naming: receiver name should not be an underscore, omit the name if it is unused (revive)
unreachable: unreachable code (govet)
rows.Err must be checked (rowserrcheck)