Add feature to TXM to detect and purge stuck transactions #12881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-momin
changed the title
dimriou
reviewed
May 22, 2024
core/config/docs/chains-evm.toml
Outdated
| # Enabled enables or disables automatically purging transactions that have been idenitified as terminally stuck (will never be included on-chain). This feature is only expected to be used by ZK chains. | ||
| Enabled = false # Default | ||
| # DetectionApiUrl configures the base url of a custom endpoint used to identify terminally stuck transactions. | ||
| DetectionApiUrl = 'https://venus.scroll.io' # Example |
There was a problem hiding this comment.
Let's not use an actual Scroll API for the example doc.
Suggested change
| DetectionApiUrl = 'https://venus.scroll.io' # Example | |
| DetectionApiUrl = 'https://example.api.io' # Example |
There was a problem hiding this comment.
Good call! Updated in the new commit
…action-feature-in-TXM
amit-momin
dismissed stale reviews from prashantkumar1982 and poopoothegorilla
via
d81da52
dimriou
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
I'm approving, although I've expressed my concerns about this implementation. I think it introduces certain complexity that will make our efforts to maintain and debug the node a bit harder. For future work, I'd suggest to explore a potentially simpler way to sync the nonce based on the on-chain mined nonce instead of tracking txs in the db.
…action-feature-in-TXM
prashantkumar1982
previously approved these changes
May 24, 2024
|
prashantkumar1982
approved these changes
May 26, 2024
dimriou
approved these changes
May 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dimriou
deleted the
BCI-2941-Implement-auto-purge-stuck-transaction-feature-in-TXM
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StuckTxDetectorcomponent that can detect stuck transaction either with a chain specific method or through a heuristicStuckTxDetectorcomponent to know which transactions to purge which includes the following: