-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keystone] Merge version field with ID #13136
Closed
HenryNguyen5
wants to merge
2
commits into
feature/workflow_validation_json_schema
from
chore/KS-162-Remove-version-field-from-any-keystone-related-structs
Closed
[Keystone] Merge version field with ID #13136
HenryNguyen5
wants to merge
2
commits into
feature/workflow_validation_json_schema
from
chore/KS-162-Remove-version-field-from-any-keystone-related-structs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryNguyen5
commented
May 8, 2024
go.mod
Outdated
@@ -353,4 +353,6 @@ replace ( | |||
|
|||
// until merged upstream: https://github.com/mwitkow/grpc-proxy/pull/69 | |||
github.com/mwitkow/grpc-proxy => github.com/smartcontractkit/grpc-proxy v0.0.0-20230731113816-f1be6620749f | |||
|
|||
github.com/smartcontractkit/chainlink-common => github.com/smartcontractkit/chainlink-common v0.1.7-0.20240508040426-71ba75fc999f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, remove this after merging in the chainlink-common PR
HenryNguyen5
force-pushed
the
chore/KS-162-Remove-version-field-from-any-keystone-related-structs
branch
from
May 8, 2024 04:33
6fe70cb
to
211da98
Compare
HenryNguyen5
force-pushed
the
chore/KS-162-Remove-version-field-from-any-keystone-related-structs
branch
from
May 8, 2024 04:41
211da98
to
0c46ab6
Compare
cedric-cordenier
approved these changes
May 9, 2024
krehermann
approved these changes
May 15, 2024
HenryNguyen5
force-pushed
the
feature/workflow_validation_json_schema
branch
from
May 23, 2024 22:17
557ef06
to
416f8d0
Compare
HenryNguyen5
force-pushed
the
chore/KS-162-Remove-version-field-from-any-keystone-related-structs
branch
from
May 23, 2024 22:31
0c46ab6
to
8fcd015
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-PR smartcontractkit/chainlink-common#502