Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate keystone workflows + Enforce full semver on capabilities #13328

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

HenryNguyen5
Copy link
Collaborator

@HenryNguyen5 HenryNguyen5 commented May 25, 2024

This PR contains the following changes:

  • Workflow definitions now enforce that a full capability semver must be specified. No version ranges are allowed.
  • Validation for workflow YAMLs is now enabled.
  • The CapabilityInfo struct now embeds the version as part of the ID itself, rather than having it as a separate field.

Prior arts:

Related PR: smartcontractkit/chainlink-common#536

@HenryNguyen5 HenryNguyen5 force-pushed the chore/refactor_keystone_schema branch from 6a91682 to 77fa66b Compare June 3, 2024 23:00
@HenryNguyen5 HenryNguyen5 force-pushed the chore/refactor_keystone_schema branch from 642bc07 to 07f2d48 Compare June 4, 2024 19:11
@HenryNguyen5 HenryNguyen5 force-pushed the chore/refactor_keystone_schema branch from e5b96f4 to ebca00d Compare June 4, 2024 19:37
@HenryNguyen5 HenryNguyen5 changed the title chore/refactor keystone schema Validate keystone workflows + Enforce full semver on capabilities Jun 4, 2024
@HenryNguyen5 HenryNguyen5 marked this pull request as ready for review June 4, 2024 20:12
@HenryNguyen5 HenryNguyen5 requested review from a team as code owners June 4, 2024 20:12
"missing name",
func() string {
id := "15c631d295ef5e32deb99a10ee6804bc4af1385568f9b3363f6552ac6dbb2cef"
owner := "00000000000000000000000000000000000000aa"
Copy link
Collaborator

@DeividasK DeividasK Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The owner needs to be within the workflow spec (not the "job spec for the workflow"), as the nodes will need to get the owner from the workflow after validating signatures, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure, I kept the structure of the test cases the same as trunk. I think we should address this in a separate topic as I want to get validation for workflow specs (not job specs) merged in first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeividasK It's not part of the workflow spec (at least it wasn't last time I checked). We do pass it from the workflow spec to the RequestMetadata thus making it available to capabilities though

@HenryNguyen5 HenryNguyen5 requested a review from bolekk June 5, 2024 19:43
DeividasK
DeividasK previously approved these changes Jun 6, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 7, 2024
Merged via the queue into develop with commit 0d95942 Jun 7, 2024
106 checks passed
@cedric-cordenier cedric-cordenier deleted the chore/refactor_keystone_schema branch June 7, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants