Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CapabilitiyRegistry: Restrict nodes to a single Workflow DON #13566

Merged
merged 14 commits into from
Jun 17, 2024
Merged

CapabilitiyRegistry: Restrict nodes to a single Workflow DON #13566

merged 14 commits into from
Jun 17, 2024

Conversation

DeividasK
Copy link
Collaborator

@DeividasK DeividasK commented Jun 16, 2024 •
edited
Loading

  • Restrict nodes to a single Workflow DON; error if trying to add to more than one workflow DON.
  • A few minor gas optimizations.
  • NodeInfo => NodeParams; added NodeInfo with full Node struct.

@DeividasK DeividasK marked this pull request as ready for review June 16, 2024 16:48
cds95
cds95 previously approved these changes Jun 16, 2024
View reviewed changes
@DeividasK DeividasK enabled auto-merge June 17, 2024 10:49
@DeividasK DeividasK added this pull request to the merge queue Jun 17, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@DeividasK DeividasK added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@DeividasK DeividasK added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@DeividasK DeividasK added this pull request to the merge queue Jun 17, 2024
Merged via the queue into develop with commit f1d478d Jun 17, 2024
108 checks passed
@DeividasK DeividasK deleted the dk-capability-registry-one-workflow-don branch June 17, 2024 15:58
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@cds95 cds95 cds95 left review comments

@bolekk bolekk Awaiting requested review from bolekk

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeividasK @archseer @cedric-cordenier @cds95