Clean up scheduler and rest of store on CTRL C #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Ellis <email@steveell.is>
se3000
force-pushed
the
features/trap-ctrl-c-gracefully
branch
from
9015e9e
to
173fc45
Compare
jordanbonilla
pushed a commit
that referenced
this pull request
Feb 15, 2018
…efully Clean up scheduler and rest of store on CTRL C
rupurt
added a commit
that referenced
this pull request
Apr 8, 2019
rupurt
pushed a commit
that referenced
this pull request
Jan 22, 2020
…-start-script Updated package start script
rupurt
pushed a commit
that referenced
this pull request
Jan 23, 2020
…-start-script Updated package start script
rupurt
pushed a commit
that referenced
this pull request
Jan 23, 2020
…-start-script Updated package start script
rupurt
pushed a commit
that referenced
this pull request
Jan 29, 2020
…-start-script Updated package start script
rupurt
pushed a commit
that referenced
this pull request
Jan 31, 2020
…-start-script Updated package start script
rupurt
pushed a commit
that referenced
this pull request
Jan 31, 2020
…-start-script Updated package start script
connorwstein
added a commit
that referenced
this pull request
Oct 18, 2021
* V3 listener working with integration test * Testing offchain sim * Address misc audit feedback * Cleanup * Lints, fix MaliciousConsumer test and add a reserved link test * Fmt and fix linter after rebasing * Contract lint * Little more time for tx fulfillment * Some comments about gasAfterPaymentCalc * Address go feedback * Add tiered fees * More tiers * Remove unused event and include fallback linketh price in public config * Bump timeouts on FM tests and remove redundant app stop * Fix FM tests, remove unused import * One more Co-authored-by: autorebase-bot <92488320+autorebase-bot@users.noreply.github.com> Co-authored-by: Jordan Krage <jmank88@gmail.com>
jmank88
added a commit
that referenced
this pull request
Jun 9, 2023
jmank88
added a commit
that referenced
this pull request
Jun 9, 2023
jmank88
added a commit
that referenced
this pull request
Jun 9, 2023
jmank88
added a commit
that referenced
this pull request
Jun 9, 2023
jmank88
added a commit
that referenced
this pull request
Jun 9, 2023
jmank88
added a commit
that referenced
this pull request
Jun 9, 2023
ilija42
added a commit
that referenced
this pull request
Jun 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
* Move FulfillResultCodes to interfaces folder * Rename Function.sol setArgs -> addArgs * Rename Routable s_config_hash -> s_configHash * Make Routable updateConfig public for re-use in constructor * Move comment out of IConfigurable * Make Routable s_router private with an internal getter * Rename constant to ROUTER_ID * Rename RouterBase s_config_hash -> s_configHash * Rename Routable.sol -> HasRouter.sol * Add IOwnableRouter interface * FunctionsSubscriptions MustBeSubOwner -> MustBeSubscriptionOwner * Make RouterBase variable private * RouterBase togglePause -> pause/unpause * Use full semantic version in typeAndVersion * ToS Allow List rename proof -> signature * Change acceptTermsOfService arguments from signature to raw r,s,v * Prettier format 💅 * Remove RouterBase versioning * Move RequestTimedOut event to Router * Rename requestSubscriptionOwnerTransfer -> proposeSubscriptionOwnerTransfer * (test): Update tests for changes * (test): Add v0 gas test * Regenerate geth wrappers * Use FulfillResult within FunctionsRouter * FunctionsRouter getConfig getter * Strip down FunctionsClient.sol * Rename GAS_FLAX_INDEX -> MAX_CALLBACK_GAS_LIMIT_FLAGS_INDEX * Use named params in structs in FunctionsRouter * Use named params in RouterBase.sol * Split overloaded getContractById into getContractById & getProposedContractById * Cast IFunctionsCoordinator earlier in the sendRequest flow * Split updateConfig flow into updateConfigSelf vs. updateConfig * Reduce contract size by removing Router's config hash getter * Remove second ToS Allow List message helper * FunctionsRouter assign variable for fulfillmentCost * Use abi.encode to convert bytes32 -> bytes * Turn RouterBase.validateProposedContracts -> FunctionsRouter.sendRequestToProposed * Add extra guards against double applying config updates * Delete contract proposal set once applied * Re-use _onlySubscriptionOwner * Pass _pay gasUsed as uint96 * Remove config hashes * Regenerate geth wrappers * Amend merge conflict * Regenerate geth wrappers * Prettier & gethwrappers * (test): amend foundry test
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Reapply: s_router is private * Create libraries folder, move Functions->FunctionsRequest & FunctionsResponse types in * Revert HasRouter back to Routable, add natspec * Separate Functions library Buffer import from CBOR * Functions library, using before all * (doc): Add more comments to Functions Request library * Document and clean up FunctionsClient * Geth wrappers * Add more ToS allowlist events * s_router -> i_router * RouterBase: timelock to uint64, remove doubled Paused getter, if statement revert style * Remove unused OCR hooks * make flags index var name more clear & add comment about internal function modifiers * Regenerate geth wrappers * Various size reducing measures * (test): Amend RouterBase pausable test for new getter
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
* utility for managing group of goroutines * refactor context to StopChan * remove limits * leftovers * leftovers round #2 * lint
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* WIP#1 * WIP#2 * WIP#3 * WIP#4 * WIP#5 * WIP#6 * wIP#7 - overrides and validations for vrfv2 * wIP#8 - overrides and validations for vrfv2lus * WIP#9 - adjust vrfv2/plus default configs * fix test config test, add logger to it * smoke tests should work now * fix replace, fix workflow * try to remove newlines from base64 * update ctf version, fix line wrap * use newer version of ctf, fix log poller and workflow issues * expand selected networks to array * fix vrfv2 smoke test, mask baseb4 override * define base64 override before masking it * a couple of masks more * set some content for BASE64_CONFIG_OVERRIDE so that it's masked * remove masks that break toml config * experiment with base64 #1 * fix ocr2 smoke test * fix lints * baseb4 experiment #2 * base64 experiment #3 * hardcode some image * exp#5 * fail config test on purpose * fix lints * run all smoke tests * add missing test config to ocr2 test * add missing loki_url * remove old config files, set config override for remote runner * fix compile errors * fix lint * make the vrfv2plus name in test matrix unique * fix loki env config, adjust vrfv2 and vrfv2plus tests and configs * add TOML-specific overriding of CL image/version in k8s * fixed automation load test * couple small fixes to how helm is created * remove multiple config files, store all config versions in single product-specific toml file * go.mod * restore deleted test, fix vrfv2 smoke tests * fix vrfv2plus config validation * properly fix vrfv2plus smoke test * fix loki basic auth passing * add add-mask again to base64 * remove obsolete configs, use latest ctf, adjust tomls * try another base64 hiding * go.sum * fix loki compile issue * try base64 env var with _SECRET suffix * try yet another variable name * restore old env var name * another obscuring attempt * another attempt * use newer CTF version, check what env vars are forwaded to k8s * go.sum * updated to latest ctf * try on demand autonation test with base64 input * modify all other test workflows so that they use TOML config * update reamdes, example envs and some more workflows * uncomment solana tests * update to latest ctf * update to latest ctf * go.mod * add MustCopy() method to TestConfig, fix failing vrvf2plus test * fix duration usages * fix lints * added examples of full configs for each product * use latest ctf * simplify some examples, correct client compatibility workflow * go.mod * copy TOML configs before executing test binary in compatibility job * use bash not sh to run the script, add missing patterns * chmod script and run it * add debug * print vars before checking their number * another debug attempt * try double quotes * store script and run that * fix script formatting * fix correct script 🤦 * fix zip command * fix upload artifact path * add some debug * update tracing readme, use latest ctf * latest ctf * lastest ctf * check what is the config missing * add missing pyrscope enabled var * remove debug * don't notify Adam if eth client compatibility test fail * latest ctf, faster eth2 chain by default * latest ctf, slots per epoch = 2 * go.sum * move convert_to_toml_array() bash function to a file and import it in GHA workflows instead of constantly defining before using * provide default configs to live testnet tests that use test binary * pass network config between jobs correctly * set .root_dir for live testnet job * try passing * try with defined output * define correct output for build-tests job * fix value name * debug * 2x base64 * try with shorter variable * add network config to dynamic config * include shared function * embed toml configs when build tag is present * test passing shared functions as outputs * update action version * remove newline from base64 * newer gha * fix log poller path, adjust client compatibility test to not copy tomls * debug * once more * do not use shared function * use correct network toml key for sepolia * fix dynamic toml * fix tomls * fix sepolia endpoint, uncomment slack notifications * remove outputs shared function from clients compatibility tests * fix alfajores once and for all * use newer gha to build tests * don't fail if there's no embedded config * remove tests we don't need anymore * use commit from main version of GHA repository instead of branch commit for build tests action * simplify config overriding * fix go.mod * remove ApplyOverride() and fix compile issue * fix lint * try base64 value extraction * try anothe approach * yet another attempt * yet another attempt 2 * fix base64 from input * one more time with final config * last test * make automation-ondemand test more secure, remove debug from on-demand-vrfv2-performance-test.yml * uncommet test execution in vrfv2 performance workflow * use private eth networks instead of geth in vrf load tests * update TOML keys related to Loki and Grafana * by default use pow, not pos * go.mod * latest ctf * remove references to deleted performance test suite * don't require Loki config when using remote runner * latest ctf * add Load config and figure out overrides * append loki config to ocr soak test on demand job * embed test configs and create .root_dir, when building test image * define an interface for global test config * move interface to testconfig * set pyroscope env for cron * fix check for remote running * bump CTF * use interfaces in public methods instead of TestConfig * small adjustments * fix test env builder * fix automation config type cast * use latest ctf * add special handling for slice override for Automation * update examples * slightly adjust vrfv2 configs, remove default empty values * move creation of base64 config override env var in smoke tests to a GHA action * fix compile error * debug for ocr test, camelcase for base64 action, two new actions to reduce loc * checkout repo before accessing actions * remove unnecessary test config instance from ocr test * mask before using input, more ocr debug * remove debug, fix reading named configurations from base64 override * mask input before using merge base64 action * fix integration tests workflow * update default.toml, add action for live testnet tests * download test binary after creating base64 env var * fix missing log targets * comment out reporting part * reuse live testnets specific action * fix network names * use dynamic network key * fix automation tests (#11815) * fix automation benchmark test action * update default toml * try newer run tests action * another try * look for .root_dir even deeper * Update integration-tests/benchmark/keeper_test.go * Update integration-tests/test.Dockerfile --------- Co-authored-by: Bartek Tofel <bartek.tofel@smartcontract.com> * fix chain config for eth2 compatibility tests * replace in-workflow toml generation for CL version upgrade tests with GH action * make test timeout configurable in client compatbility tests * prepare base64 config for log poller matrix tests --------- Co-authored-by: Ilja Pavlovs <ilja.pavlovs@gmail.com> Co-authored-by: skudasov <f4hrenh9it@gmail.com> Co-authored-by: Gheorghe Strimtu <studentcuza@gmail.com> Co-authored-by: Anirudh Warrier <12178754+anirudhwarrier@users.noreply.github.com>
DeividasK
added a commit
that referenced
this pull request
Jun 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Minor gas saving refactor * Minor gas saving refactor #2 * Split DON IDs into capabilities and workflow * Validate that a node can belong to a single Workflow DON * Update gas snapshot and wrappers * Align error messages * Changesets * NodeInfo => NodeParams * Add NodeInfo * Update gas snapshot and wrappers * Update reader integration test * Fix Reader test * Simplify changes * Comment fix
Tofel
added a commit
that referenced
this pull request
Aug 2, 2024
# This is the 1st commit message: update contract # This is the commit message #2: make scripts executable # This is the commit message #3: upload base too # This is the commit message #4: try again # This is the commit message #5: gather changesets, print products out of scope # This is the commit message #6: fix product finding # This is the commit message #7: try again # This is the commit message #8: debug # This is the commit message #9: debug 2 # This is the commit message #10: grab only modified or added changesets # This is the commit message #11: try again 1 # This is the commit message #12: remove early exit # This is the commit message #13: place changesets in a subfolder in final artifact # This is the commit message #14: validate whether everything was generated
Tofel
added a commit
that referenced
this pull request
Aug 2, 2024
# This is the 1st commit message: fetch whole repo # This is the commit message #2: add comment # This is the commit message #3: fix paths for validation # This is the commit message #4: try with functions # This is the commit message #5: fix spelling # This is the commit message #6: display failed UML generation once
Tofel
added a commit
that referenced
this pull request
Aug 5, 2024
# This is the 1st commit message: CR changes + test them # This is the commit message #2: use shell array
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
* More univeral lcov prunning * update Shared code cov * exclude deleted files from Slither * use single source of truth for all Solidity Foundry jobs * fix json * compact output with jq * fix condition for fmt * try to scope tests to changes * move matrix check to step level * fix outputs path * trigger * test with Automation change * try with shared * run fmt also if any sol files were modified * fix job name in collect metrics * trigger pipeline only for localised change + update changes info * add changeset * remove test change * do not run forge fmt if shared contracts have changed * try artifact pipeline by hijacking hardhat * # This is a combination of 2 commits. # This is the 1st commit message: CR changes + test them # This is the commit message #2: use shell array * CR changes + test them use shell array init array CR changes + test them use shell array init array * remove test files * do not run Slither for test files * do not run fmt if test files were modified * remove unused config file * restore old Hardhat pipeline * add missing transmission setup * fix basic info condition, join 2 steps into 1, define higher-level coverage exclusions * define actions for installing Slither and solc-select * run all tests also if package.json changes; run them on all non_src changes * add action for validating whether all Slither reports and UML diagrams were generated * fetch origin in validation action * compare with HEAD in validate action * compare with origin in validation action * handle both csv and shell arrays in the validation action * update artifact pipeline with new actions * fix workflow after tests * fix how validation actions works with commits * treat shared as any other product * small fixes * apply CR changes * remove special handling for deleted files * remove apt-get update * use only dorny/paths * remove unused input * CR changes: use dorny/paths with quantifier, move scope validation to an action, remove whitespaces * fix workflow * fail bash scripts on erors * add set -euo pipefail to bash scripts * define action to detect foundry version * fix select solc version script, better slither report output * checkout repo * add id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTRL+C is trapped, resulting in store and scheduler cleanup.
Tracker story: https://www.pivotaltracker.com/story/show/153524353