Various test cleanups and optimizations #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevents deadlock with running store and test - Reduces contention with parallelized tests
se3000
reviewed
Jan 16, 2018
| @@ -31,22 +31,23 @@ func TestLoadingSavedSchedules(t *testing.T) { | |||
| Eventually(func() []models.JobRun { | |||
| store.Where("JobID", j.ID, &jobRuns) | |||
| return jobRuns | |||
| }).Should(HaveLen(1)) | |||
| }).Should(cltest.HaveLenAtLeast(1)) | |||
se3000
reviewed
Jan 16, 2018
| t.Parallel() | ||
| RegisterTestingT(t) | ||
| store, cleanup := cltest.NewStore() | ||
| defer cleanup() | ||
|
|
||
| sched := services.NewScheduler(store) | ||
| sched.Start() | ||
| defer sched.Stop() |
se3000
reviewed
Jan 16, 2018
| @@ -15,7 +15,7 @@ func TestJobSave(t *testing.T) { | |||
| store, cleanup := cltest.NewStore() | |||
| defer cleanup() | |||
|
|
|||
| j1 := cltest.NewJobWithSchedule("* * * * *") | |||
| j1 := cltest.NewJobWithSchedule("* * * * 7") | |||
There was a problem hiding this comment.
This is so it is different than our test defaults?
There was a problem hiding this comment.
I overreacted on this one. In general, I'm just very wary of the cron jobs that run every second, so I tried to remove the ones that didn't need it. I don't think this test even uses a scheduler so it's moot.
se3000
reviewed
Jan 16, 2018
| @@ -9,7 +9,6 @@ import ( | |||
| ) | |||
|
|
|||
| func TestGracefulShutdown(t *testing.T) { | |||
| t.Parallel() | |||
jordanbonilla
pushed a commit
that referenced
this pull request
Feb 15, 2018
…s-test-pt1 Various test cleanups and optimizations
rupurt
pushed a commit
that referenced
this pull request
Jan 22, 2020
…sation-for-FX-Commodity-contracts-on-Mainnet Create visualisation for FX/Commodity contracts on Mainnet
rupurt
pushed a commit
that referenced
this pull request
Jan 23, 2020
…sation-for-FX-Commodity-contracts-on-Mainnet Create visualisation for FX/Commodity contracts on Mainnet
rupurt
pushed a commit
that referenced
this pull request
Jan 23, 2020
…sation-for-FX-Commodity-contracts-on-Mainnet Create visualisation for FX/Commodity contracts on Mainnet
rupurt
pushed a commit
that referenced
this pull request
Jan 29, 2020
…sation-for-FX-Commodity-contracts-on-Mainnet Create visualisation for FX/Commodity contracts on Mainnet
rupurt
pushed a commit
that referenced
this pull request
Jan 31, 2020
…sation-for-FX-Commodity-contracts-on-Mainnet Create visualisation for FX/Commodity contracts on Mainnet
rupurt
pushed a commit
that referenced
this pull request
Jan 31, 2020
…sation-for-FX-Commodity-contracts-on-Mainnet Create visualisation for FX/Commodity contracts on Mainnet
Tofel
added a commit
that referenced
this pull request
Aug 2, 2024
# This is the 1st commit message: update contract # This is the commit message #2: make scripts executable # This is the commit message #3: upload base too # This is the commit message #4: try again # This is the commit message #5: gather changesets, print products out of scope # This is the commit message #6: fix product finding # This is the commit message #7: try again # This is the commit message #8: debug # This is the commit message #9: debug 2 # This is the commit message #10: grab only modified or added changesets # This is the commit message #11: try again 1 # This is the commit message #12: remove early exit # This is the commit message #13: place changesets in a subfolder in final artifact # This is the commit message #14: validate whether everything was generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.