Aptos LOOP setup #14076
Aptos LOOP setup #14076
Conversation
|
I see you updated files related to
|
| // the plugin should handle it's own defaults and merging | ||
| c.Aptos = f.Aptos |
There was a problem hiding this comment.
This is unfortunately not so simple, because we also support passing multiple files that override one another. I can't think of a simple short-term fix, but this will have to be solved another way eventually regardless 🤔
There was a problem hiding this comment.
could you concat the files together, then only do the parse once?
There was a problem hiding this comment.
Plain concat only works in special cases. We could write logic to crawl through the maps and set individual fields, but I'm not sure how easy that will be 🤔
Blake2b costs about a third of SHA2/SHA3/keccak256 https://aptos.dev/en/build/smart-contracts/cryptography
Really painful on slower internet connections
| TOMLConfigs RawConfigs | ||
| } | ||
|
|
||
| func (r *RelayerFactory) NewAptos(ks keystore.Aptos, chainCfgs RawConfigs) (map[types.RelayID]loop.Relayer, error) { |
There was a problem hiding this comment.
nit: shouldn't we use the AptosFactoryConfig as input param here?
| @@ -301,3 +301,65 @@ func (r *RelayerFactory) NewCosmos(config CosmosFactoryConfig) (map[types.RelayI | |||
| } | |||
| return relayers, nil | |||
| } | |||
|
|
|||
| type AptosFactoryConfig struct { | |||
There was a problem hiding this comment.
[non-blocking discussion] We should also ideally get Beholder integrated and configured in the core Node itself, and then inject it here to make it available to the LOOP as a common core service. @mathewdgardner wdyt?
There was a problem hiding this comment.
Draft in progress here to follow beholder client PR: smartcontractkit/chainlink-common#696
| return r.NewLOOPRelayer("Aptos", corerelay.NetworkAptos, plugin, loopKs, chainCfgs) | ||
| } | ||
|
|
||
| func (r *RelayerFactory) NewLOOPRelayer(name string, network string, plugin env.Plugin, ks coretypes.Keystore, chainCfgs RawConfigs) (map[types.RelayID]loop.Relayer, error) { |
There was a problem hiding this comment.
nit: consider grouping the keystore, config, and capRegistry in a type like PluginContext
| @@ -88,6 +85,9 @@ func (akr *aptosKeyring) verifyBlob(pubkey ocrtypes.OnchainPublicKey, b, sig []b | |||
| if len(sig) != akr.MaxSignatureLength() { | |||
| return false | |||
| } | |||
| // we ignore the passed in publicKey since that will be the EVM key if using multi-chain config | |||
| // instead we use the embedded publicKey that's part of the ed25519 signature | |||
| pubkey = sig[:32] | |||
There was a problem hiding this comment.
Hmm, this feels like magic. Shouldn't the caller configure this on input?
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.