Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aptos (combined branch) #13716

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Aptos (combined branch) #13716

wants to merge 3 commits into from
+228 −1

Conversation

archseer
Copy link
Contributor

@archseer archseer commented Jun 28, 2024 •
edited
Loading

Contains #14076, #14078 and staged changes

archseer
archseer commented Jun 28, 2024
View reviewed changes
core/services/chainlink/relayer_factory.go Outdated
Comment on lines 313 to 315
plugin := env.NewPlugin("aptos")
loopKs := &keystore.AptosLooppSigner{Aptos: ks}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps all this can be moved into InitAptos?

Base automatically changed from BCI-2953-Aptos-Keystore to develop July 2, 2024 03:37
bolekk
bolekk reviewed Jul 31, 2024
View reviewed changes
core/capabilities/streams/mock_trigger.go
return flat
}

const triggerID = "mock-streams-trigger@1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having this merged as an example trigger. I only wish it could go to common but it can't because of EVM dep :( Maybe we should create a special sub-directory with example capabilities and move on-demand trigger there as well...? @cedric-cordenier thoughts?

core/scripts/keystone/main.go Outdated Show resolved Hide resolved
core/services/chainlink/application.go
@@ -206,6 +207,13 @@ func NewApplication(opts ApplicationOpts) (Application, error) {
opts.CapabilitiesRegistry = capabilities.NewRegistry(globalLogger)
}

// Use a recurring trigger with mock data for testing purposes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing where? Can it be under some flag? It doesn't seem right to always add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move this inside the mock_trigger.go, that way it's only used if the capability is used

@archseer archseer changed the base branch from develop to fix-multichain-keybundle September 9, 2024 10:15
@archseer archseer force-pushed the aptos-init branch 2 times, most recently from 49f092c to bf2f114 Compare September 9, 2024 12:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@archseer archseer force-pushed the aptos-init branch 3 times, most recently from 820f8f6 to e01302f Compare September 10, 2024 13:23
@archseer archseer force-pushed the aptos-init branch 2 times, most recently from 9abfa6f to c4351e3 Compare September 11, 2024 06:16
@krebernisak krebernisak mentioned this pull request Sep 16, 2024
Closed
Base automatically changed from fix-multichain-keybundle to develop September 17, 2024 14:55
@archseer archseer force-pushed the aptos-init branch 2 times, most recently from e255623 to b73c5ff Compare September 18, 2024 09:49
@archseer archseer force-pushed the aptos-init branch 2 times, most recently from 6453f9f to 0bf0cc1 Compare September 25, 2024 07:26
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
8 New Major Issues (required ≤ 5)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@archseer @bolekk @krebernisak @smickovskid