Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aptos (combined branch) - update to latest develop #14447

Closed
wants to merge 10 commits into from

Conversation

krebernisak
Copy link
Contributor

Updates (rebases) #13716 to latest develop.

Original is kept stable for other folks working on it.

@krebernisak krebernisak requested review from a team as code owners September 16, 2024 18:10
@krebernisak krebernisak requested review from jmank88 and removed request for a team September 16, 2024 18:10
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@krebernisak krebernisak requested review from a team as code owners September 17, 2024 10:40
@krebernisak krebernisak changed the base branch from develop to fix-multichain-keybundle September 17, 2024 10:40
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
8 New Major Issues (required ≤ 5)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@krebernisak
Copy link
Contributor Author

Closing for the original #13716 which is now rebased to latest

@krebernisak
Copy link
Contributor Author

Closing for the original #13716 which is now rebased to latest

@archseer archseer deleted the aptos-init-develop branch September 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants