Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functions] (test): Don't skip gas golf test #9924

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

justinkaseman
Copy link
Contributor

.skip was making the test hang as pending locally. This will allow running locally without an extra step of removing the .skip

@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 1 New Blocker Issues (is greater than 0)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@justinkaseman justinkaseman added this pull request to the merge queue Jul 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2023
@justinkaseman justinkaseman added this pull request to the merge queue Jul 25, 2023
Merged via the queue into develop with commit 970a052 Jul 25, 2023
95 of 96 checks passed
@justinkaseman justinkaseman deleted the jk/gas-golf-no-skip branch July 25, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants