Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functions] (test): Don't skip gas golf test #9924

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[Functions] (test): Don't skip gas golf test #9924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions contracts/test/v0.8/functions/v1/GasGolf.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const setup = getSetupFactory()
let contracts: FunctionsContracts
let roles: FunctionsRoles

const baselineGasUsed = 931_695 // TODO: Update baseline
const baselineGasUsed = 933_007 // TODO: Baseline will be updated at the start of 7/27
let currentGasUsed = 0

beforeEach(async () => {
Expand All @@ -29,8 +29,8 @@ after(() => {
console.log(`\n 🚩 Score : ${score} gas`)
})

describe.skip('Gas Golf', () => {
it('- taking a swing', async () => {
describe('Gas Golf', () => {
it('taking a swing', async () => {
// User signs Terms of Service
const messageHash = await contracts.accessControl.getMessageHash(
roles.consumerAddress,
Expand Down Expand Up @@ -95,8 +95,5 @@ describe.skip('Gas Golf', () => {
.add(requestTxGasUsed)
.add(fulfillmentTxGasUsed)
.toNumber()

expect(currentGasUsed).to.be.greaterThan(0)
expect(currentGasUsed).to.be.lessThan(baselineGasUsed)
})
})
Loading