Merge pull request #888 from smbc-digital/revertIntegrityCheck

revert(GeneratedIdConfigurationCheck): comment out added check to inv…
smbc-digital · Nov 9, 2023 · 27c9041 · 27c9041
2 parents 3c3d665 + 6f2f83a
commit 27c9041
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Validators/IntegrityChecks/Form/GeneratedIdConfigurationCheck.cs b/src/Validators/IntegrityChecks/Form/GeneratedIdConfigurationCheck.cs
@@ -15,9 +15,9 @@ public IntegrityCheckResult Validate(FormSchema schema)
                     "Generated Id Configuration Check, " +
                     "'GeneratedReferenceNumberMapping' and 'ReferencePrefix' must both have a value.");
 
-            if (schema.Pages.Any(page => page.Behaviours.Any(behaviour => behaviour.BehaviourType.Equals(EBehaviourType.SubmitWithoutSubmission))) && !schema.GenerateReferenceNumber)
-                result.AddFailureMessage(
-                    "Generated Id Configuration Check, if using SubmitFormNoAction then 'GeneratedReferenceNumber' must be true.");
+            //if (schema.Pages.Any(page => page.Behaviours.Any(behaviour => behaviour.BehaviourType.Equals(EBehaviourType.SubmitWithoutSubmission))) && !schema.GenerateReferenceNumber)
+            //    result.AddFailureMessage(
+            //        "Generated Id Configuration Check, if using SubmitFormNoAction then 'GeneratedReferenceNumber' must be true.");
 
             return result;
         }

diff --git a/tests/unit-tests/UnitTests/Validators/IntegrityChecks/Form/GeneratedIdConfigurationTests.cs b/tests/unit-tests/UnitTests/Validators/IntegrityChecks/Form/GeneratedIdConfigurationTests.cs
@@ -67,7 +67,7 @@ public void CheckGeneratedIdConfiguration_DoesNotThrow_ApplicationException_Gene
             Assert.DoesNotContain(IntegrityChecksConstants.FAILURE, result.Messages);
         }
 
-        [Fact]
+        [Fact(Skip = "Skipped for investigation")]
         public void CheckGeneratedIdConfiguration_Throw_ApplicationException_WhenGenerateReferenceNumber_IsFalse_And_SubmitWithoutSubmission_IsUsed()
         {
             // Arrange