Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leucine to chymotrypsin cleavage motifs #2336

Conversation

trishorts
Copy link
Contributor

@trishorts trishorts commented Jan 23, 2024

I found an omission in the list of motifs digested by chymotrypsin. This PR fixes that omission and tests that it results in finding chymotrypsin digested peptides ending in Leucine.

image
https://www.sigmaaldrich.com/US/en/technical-documents/technical-article/protein-biology/protein-labeling-and-modification/chymotrypsin

@trishorts trishorts added Bug WIP Work in progress, not ready for review labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15627fc) 92.63% compared to head (5c506ef) 92.68%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
+ Coverage   92.63%   92.68%   +0.05%     
==========================================
  Files         136      136              
  Lines       21302    21302              
  Branches     2924     2924              
==========================================
+ Hits        19733    19744      +11     
+ Misses       1095     1086       -9     
+ Partials      474      472       -2     

see 2 files with indirect coverage changes

@trishorts trishorts added ready for review and removed WIP Work in progress, not ready for review labels Jan 23, 2024
Copy link
Member

@nbollis nbollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a new toml needed or can an old toml be used and the Protease changed?

@nbollis nbollis merged commit da174f0 into smith-chem-wisc:master Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants