-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leucine to chymotrypsin cleavage motifs #2336
Merged
nbollis
merged 17 commits into
smith-chem-wisc:master
from
trishorts:addLeucineToChymotrypsinCleavageMotifs
Feb 5, 2024
Merged
Add leucine to chymotrypsin cleavage motifs #2336
nbollis
merged 17 commits into
smith-chem-wisc:master
from
trishorts:addLeucineToChymotrypsinCleavageMotifs
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2336 +/- ##
==========================================
+ Coverage 92.63% 92.68% +0.05%
==========================================
Files 136 136
Lines 21302 21302
Branches 2924 2924
==========================================
+ Hits 19733 19744 +11
+ Misses 1095 1086 -9
+ Partials 474 472 -2 |
trishorts
added
ready for review
and removed
WIP
Work in progress, not ready for review
labels
Jan 23, 2024
trishorts
requested review from
acesnik,
Alexander-Sol,
YulingDai,
elaboy,
kyp4,
nbollis,
zhuoxinshi and
RayMSMS
January 23, 2024 18:26
elaboy
approved these changes
Jan 23, 2024
nbollis
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a new toml needed or can an old toml be used and the Protease changed?
YulingDai
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an omission in the list of motifs digested by chymotrypsin. This PR fixes that omission and tests that it results in finding chymotrypsin digested peptides ending in Leucine.
https://www.sigmaaldrich.com/US/en/technical-documents/technical-article/protein-biology/protein-labeling-and-modification/chymotrypsin