Add leucine to chymo cleavage motif #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
nbollis,
zhuoxinshi and
RayMSMS
nbollis
approved these changes
Feb 2, 2024
trishorts
changed the title
YulingDai
approved these changes
Feb 2, 2024
elaboy
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an error in the MetaMorpheus proteases.tsv where leucine was accidentally omitted from the chymotrypsin cleavage motifs. I made a change there smith-chem-wisc/MetaMorpheus#2336 and did all the appropriate unit testing. Nic reminded me that we have to make the change here too. So, here it is.
In the future, we should consolidate update MM to use only this file and eliminate the redundancy.