Shared peptides tic box for lfq #2353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2353 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 136 136
Lines 21229 21232 +3
Branches 2928 2928
=======================================
+ Hits 19668 19671 +3
Misses 1083 1083
Partials 478 478
|
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
nbollis,
zhuoxinshi and
RayMSMS
Merged
Alexander-Sol
requested changes
Feb 27, 2024
There was a problem hiding this comment.
The tick box should go next to the other boxes, probably below "Normalize quantification results." Also needs a tooltip
I made these changes myself in #2354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important back and forth on twitter today about the inclusion of shared peptides for label free quant. General sentiment is no, which has been the default parameter that we use in MetaMorpheus for flashlfq. However, the flashlfq app gives the user the option. Therefore I added a checkbox to the quantification section of the search task that allows the user to choose. The default is still to not include them.