Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared pep box #2354

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Shared pep box #2354

merged 5 commits into from
Feb 28, 2024

Conversation

Alexander-Sol
Copy link
Contributor

@Alexander-Sol Alexander-Sol commented Feb 27, 2024

Same as PR #2353, but the tick box behavior matches that of other LFQ tick boxes. And a tooltip was added.

Important back and forth on twitter today about the inclusion of shared peptides for label free quant. General sentiment is no, which has been the default parameter that we use in MetaMorpheus for flashlfq. However, the flashlfq app gives the user the option. Therefore I added a checkbox to the quantification section of the search task that allows the user to choose. The default is still to not include them.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (1085594) to head (a68a2b7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2354   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         136      136           
  Lines       21229    21232    +3     
  Branches     2928     2928           
=======================================
+ Hits        19668    19671    +3     
  Misses       1083     1083           
  Partials      478      478           
Files Coverage Δ
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 93.36% <100.00%> (+<0.01%) ⬆️
...aMorpheus/TaskLayer/SearchTask/SearchParameters.cs 100.00% <100.00%> (ø)

@trishorts trishorts merged commit 79426aa into smith-chem-wisc:master Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants