Add incomplete Event Stream support with working Amazon Transcribe example #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
commented
Aug 17, 2021
...en/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/BuilderGenerator.kt
Outdated
Show resolved
Hide resolved
rcoh
reviewed
Aug 18, 2021
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SigV4SigningDecorator.kt
Show resolved
Hide resolved
| val initial = super.toSymbol(shape) | ||
|
|
||
| // We only want to wrap with Event Stream types when dealing with member shapes | ||
| if (shape is MemberShape && shape.isEventStream(model)) { |
There was a problem hiding this comment.
generally I structure this as a series of rule outs to remove the nesting, YMMV
...en/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/BuilderGenerator.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/HttpProtocolGenerator.kt
Show resolved
Hide resolved
codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/UnionGenerator.kt
Outdated
Show resolved
Hide resolved
...otlin/software/amazon/smithy/rust/codegen/smithy/generators/http/ResponseBindingGenerator.kt
Outdated
Show resolved
Hide resolved
...ftware/amazon/smithy/rust/codegen/smithy/protocols/parse/EventStreamUnmarshallerGenerator.kt
Show resolved
Hide resolved
...ftware/amazon/smithy/rust/codegen/smithy/protocols/parse/EventStreamUnmarshallerGenerator.kt
Outdated
Show resolved
Hide resolved
rcoh
approved these changes
Aug 20, 2021
codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/CodegenDelegator.kt
Outdated
Show resolved
Hide resolved
...ftware/amazon/smithy/rust/codegen/smithy/protocols/parse/EventStreamUnmarshallerGenerator.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/software/amazon/smithy/rust/codegen/smithy/transformers/EventStreamNormalizer.kt
Outdated
Show resolved
Hide resolved
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SigV4SigningDecorator.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is progress towards adding full Event Stream support to smithy-rs (#121). In particular, this PR:
SMITHYRS_EXPERIMENTAL_EVENTSTREAMenvironment variable which, when set to1, turns off the removal of Event Stream operationsTODO(EventStream)tagsTesting
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.