Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add incomplete Event Stream support with working Amazon Transcribe example #653

Merged
merged 20 commits into from
Aug 20, 2021
Merged

Add incomplete Event Stream support with working Amazon Transcribe example #653

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1b1f13a
Add incomplete Event Stream support with working Amazon Transcribe ex…
jdisanti Aug 9, 2021
30ea274
Make the raw response in SdkError generic
jdisanti Aug 17, 2021
4d5c6c2
Fix XmlBindingTraitSerializerGeneratorTest
jdisanti Aug 17, 2021
4ce410b
Make the build aware of the SMITHYRS_EXPERIMENTAL_EVENTSTREAM switch
jdisanti Aug 17, 2021
ef47f2c
Fix SigV4SigningCustomizationTest
jdisanti Aug 17, 2021
035ee1e
Update changelog
jdisanti Aug 17, 2021
7d2ab92
Fix build when SMITHYRS_EXPERIMENTAL_EVENTSTREAM is not set
jdisanti Aug 17, 2021
7733d47
Add initial unit test for EventStreamUnmarshallerGenerator
jdisanti Aug 18, 2021
982687e
Add event header unmarshalling support
jdisanti Aug 18, 2021
a18429c
Don't pull in event stream dependencies by default
jdisanti Aug 18, 2021
f8b7954
Only add event stream signer to config for services that need it
jdisanti Aug 18, 2021
16aeade
Move event stream inlineables into smithy-eventstream
jdisanti Aug 18, 2021
52643b3
Fix some clippy lints
jdisanti Aug 18, 2021
7045bcc
Transform event stream unions
jdisanti Aug 18, 2021
33c26ed
Merge remote-tracking branch 'upstream/main' into eventstream-codegen
jdisanti Aug 18, 2021
6df5edb
Fix crash in SigV4SigningDecorator
jdisanti Aug 19, 2021
d0b147e
Add test for unmarshalling errors
jdisanti Aug 19, 2021
0aa64e5
Merge remote-tracking branch 'upstream/main' into eventstream-codegen
jdisanti Aug 19, 2021
553aec2
Incorporate CR feedback
jdisanti Aug 20, 2021
23b5244
Merge remote-tracking branch 'upstream/main' into eventstream-codegen
jdisanti Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SigV4SigningDecorator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import software.amazon.smithy.rust.codegen.util.expectTrait
import software.amazon.smithy.rust.codegen.util.hasTrait
import software.amazon.smithy.rust.codegen.util.isEventStream
import software.amazon.smithy.rust.codegen.util.isInputEventStream
import software.amazon.smithy.rust.codegen.util.orNull

/**
* The SigV4SigningDecorator:
Expand All @@ -55,8 +56,10 @@ class SigV4SigningDecorator : RustCodegenDecorator {
return baseCustomizations.letIf(applies(protocolConfig)) { customizations ->
val serviceHasEventStream = protocolConfig.serviceShape.operations
.any { id ->
protocolConfig.model.expectShape(id, OperationShape::class.java)
.isEventStream(protocolConfig.model)
// Some models like `kinesisanalytics` have StructureShapes in their operation list,
// so don't assume they're always OperationShape.
val shape = protocolConfig.model.getShape(id).orNull()
shape is OperationShape && shape.isEventStream(protocolConfig.model)
jdisanti marked this conversation as resolved.
Show resolved Hide resolved
}
customizations + SigV4SigningConfig(
protocolConfig.runtimeConfig,
Expand Down