Preact rewrite #1156
Closed
Preact rewrite #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2018
Closed
|
Just curious, but do you plan on using redux (or something similar) to manage global state/data? |
|
@walshyb Nope, we're using It's defined here: (will be easier to read if you click instead of reading inline) |
Zarel
force-pushed
the
preact-rewrite
branch
2 times, most recently
from
d4a82b2 to
38434d2
Compare
|
In-progress shot!
|
Zarel
force-pushed
the
preact-rewrite
branch
2 times, most recently
from
98a9ebb to
d70951d
Compare
Zarel
force-pushed
the
preact-rewrite
branch
3 times, most recently
from
f5d0265 to
e82e25a
Compare
|
@Zarel |
|
I'll upload it when it gets closer to done. As it is, it's very easy to test. Just check it out, run |
Zarel
force-pushed
the
preact-rewrite
branch
2 times, most recently
from
d481b4e to
84fed0d
Compare
Zarel
force-pushed
the
preact-rewrite
branch
from
84fed0d to
edbdbd3
Compare
HIGHLY UNFINISHED CODE
This is kind of a break of purity, because it reads `window.offsetWidth`, but this is the lowest-overhead way to automatically recalculate the leftRoom width whenever PS updates (i.e. whenever leftRoom or rightRoom change).
Considering all the individual panels start with `panel-`, this should make it easier to find and in general be a more intuitive name. All other tsx files will start with `panel-`, putting them together in one place when sorting alphabetically.
Room layout code is now better commented and more readable.
There's still a lot more to do, but this is a start
Unlike the old router, this one has no dependencies, and also tracks left/right panel state, for more accurate back/forward button support. It also sets the URL to the last selected panel, instead of always using the left panel.
The actual connect function is commented out, because there's no reason for it to do anything. But it can actually connect to a server now.
This at least lets me test some router features without pushing it to the live server.
Zarel
force-pushed
the
preact-rewrite
branch
from
edbdbd3 to
bdf1d79
Compare
|
Superseded by #1229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIGHLY UNFINISHED CODE