Preact rewrite #1229
Merged
Preact rewrite #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This comment has been minimized.
This comment has been minimized.
Zarel
force-pushed
the
preact-rewrite
branch
from
76152fc to
c6acdd6
Compare
This comment has been minimized.
This comment has been minimized.
Zarel
force-pushed
the
preact-rewrite
branch
from
c6acdd6 to
96f2763
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
If YOU TOO want to send messages to rooms, all you need is to add a Replace
|
This comment has been minimized.
This comment has been minimized.
Zarel
force-pushed
the
preact-rewrite
branch
from
9d99079 to
f503dd2
Compare
This comment has been minimized.
This comment has been minimized.
Zarel
force-pushed
the
preact-rewrite
branch
3 times, most recently
from
d45761c to
afd367d
Compare
This comment has been minimized.
This comment has been minimized.
HIGHLY UNFINISHED CODE
This is kind of a break of purity, because it reads `window.offsetWidth`, but this is the lowest-overhead way to automatically recalculate the leftRoom width whenever PS updates (i.e. whenever leftRoom or rightRoom change).
Considering all the individual panels start with `panel-`, this should make it easier to find and in general be a more intuitive name. All other tsx files will start with `panel-`, putting them together in one place when sorting alphabetically.
Room layout code is now better commented and more readable.
There's still a lot more to do, but this is a start
Unlike the old router, this one has no dependencies, and also tracks left/right panel state, for more accurate back/forward button support. It also sets the URL to the last selected panel, instead of always using the left panel.
The actual connect function is commented out, because there's no reason for it to do anything. But it can actually connect to a server now.
This at least lets me test some router features without pushing it to the live server.
You can't actually log in through the Preact client anyway, but now if you set the right config file, you can _be_ logged in.
Using arrow keys to switch rooms is now in! Unlike in the old client, the new system supports switching to all rooms, and supports arrow keys in all situations, rather than only being able to switch between chat rooms, and only with textareas focused. Also, focusing chat rooms now focuses the input box. This was surprisingly hard to implement with React, which has an annoying all-or-nothing approach to state it doesn't control.
This involves a relatively substantial refactor to how panels work, but it should be somewhat finalized now. Popups are now fully supported.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This is getting merged into master now! |
|
The Preact branch is nowhere near done, of course. But it's intentionally designed to be able to run parallel to the regular client, so that's what'll happen from now on. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I can't convert a pull request into a draft pull request, but I can re-create the pull request. Since the Preact rewrite is probably our longest-term project, this is probably the correct thing to do here.