-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement task::Wake
for Inner
#18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To finish the issue, you would also need something on Unparker
to expose this functionality in the API. Something like:
impl From<Unparker> for Waker {
fn from(up: Unparker) -> Self {
Waker::from(up.inner)
}
}
It seems with the implementation of Also I can't seem to run that test with features loom in my local? Do you know any reason why? |
Can you bump it in this PR? Just change the version in
You can run
It seems that we can't use |
Sure, I just want to let you know before doing it actually.
Oh okay, I will make this change then. |
Do you want me to amend the commits into one? The diff is small enough to be a single commit. |
That's okay, I'll just squash it when I review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #17.
Please suggest any changes necessary.