-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2016-June improvements #955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the shared memory path (shm.path) to a private namespace for each app with prefix "app/$name". This means that apps can create shm objects such as counters and by default these will appear in a local namespace for that app.
I rewrote the git-workflow explanation with the goal of briefly but clearly explaining both how to submit a change to Snabb Switch and also how to be a subsystem maintainer. This is intended to be a chapter in the manual.
Contains "XXX rewrite" where old sections have been removed but replacements not written yet.
This file now contains a diagram so it needs to have separate .src.md and .md versions. This can be cleaned up when these changes eventually merge with the on-demand markdown (snabbco#829).
also stopped capitalizing "Pull Request" because it seemed awkward.
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
# Conflicts: # src/core/app.lua
…eric representation.
Resolved conflicts with incoming changes from master branch: *.src.md replaced with simply *.md "Snabb Switch" being renamed to "Snabb"
Ditaa images are not kept in tree anymore...
option and support injecting a function to determine the current time.
This reverts commit 8bb3215.
# Conflicts: # src/core/counter.lua
This reverts commit 924ff4e.
This reverts commit e9f5dda.
# Conflicts: # src/apps/intel/intel10g.lua # src/core/app.lua
Otherwise it prints misleading errors: grep: jit/vmdef.lua: No such file or directory grep: program/lisper/dev-env/syscall.lua: No such file or directory grep: program/lisper/dev-env-docker/syscall.lua: No such file or directory grep: jit/vmdef.lua: No such file or directory grep: program/lisper/dev-env/syscall.lua: No such file or directory grep: program/lisper/dev-env-docker/syscall.lua: No such file or directory grep: jit/vmdef.lua: No such file or directory grep: program/lisper/dev-env/syscall.lua: No such file or directory grep: program/lisper/dev-env-docker/syscall.lua: No such file or directory grep: jit/vmdef.lua: No such file or directory grep: program/lisper/dev-env/syscall.lua: No such file or directory grep: program/lisper/dev-env-docker/syscall.lua: No such file or directory
Conflicts: - src/core/main.lua
This reverts commit c3b8672.
lukego
added a commit
that referenced
this pull request
Jun 29, 2016
dpino
pushed a commit
to dpino/snabb
that referenced
this pull request
Sep 25, 2017
Shutdown the follower properly when removing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#931 "app local statistics counters"
#941 "silence grep"
#835 "document workflows"
#930 "fork into worker/supervisor"