Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method from urls.py #137

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Remove deprecated method from urls.py #137

merged 1 commit into from
Jan 22, 2021

Conversation

xavirg
Copy link
Contributor

@xavirg xavirg commented Jan 22, 2021

url() is deprecated since Django version 3.1. A quick approach is to use the equivalent re_path() alias.

url() is deprecated since Django version 3.1.
@JonasKs
Copy link
Member

JonasKs commented Jan 22, 2021

While #131 removes official support for Django1.1, this would seal the deal and make any future release not work on Django1.1.
With that said, I agree it should be done. There is no intention of keeping Django1.1 supported for future releases.

@JonasKs JonasKs merged commit 1474cf7 into snok:master Jan 22, 2021
@xavirg
Copy link
Contributor Author

xavirg commented Jan 22, 2021

While #131 removes official support for Django1.1, this would seal the deal and make any future release not work on Django1.1.
With that said, I agree it should be done. There is no intention of keeping Django1.1 supported for future releases.

Take note that Django 1.11 extended support already expired by April 2020.

Only versions 2.2LTS or greater should be considered for current developments.

@JonasKs
Copy link
Member

JonasKs commented Jan 22, 2021

I'm aware. This change has been accepted, but would not have been necessary until Django 4.0 release, so technically it's breaking 1.1 support without any benefit. I wrote my comment not because I disagree, but because I want to document these changes very clearly for others to read.

Only versions 2.2LTS or greater should be considered for current developments.

It's important to differ between what Django core supports (security and bugfix releases) and what an open source package decides to support. It's often hand in hand, but don't have to be. That said, I have no intention of supporting 1.1, and the #138 rewrite will only work for 3.1.1 and above.

mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
Remove deprecated method from urls.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants