Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes travis and updates supported Django versions #131

Merged
merged 11 commits into from
Jan 19, 2021
Merged

Removes travis and updates supported Django versions #131

merged 11 commits into from
Jan 19, 2021

Conversation

JonasKs
Copy link
Member

@JonasKs JonasKs commented Jan 19, 2021

Thanks @sondrelg for starting the branch! ❤️

Removes Travis and implements GitHub actions.
Removes unsupported Django versions. Older versions may work (and they do), but are no longer officially supported. This is to make the library easily maintainable.
Prepares implementation of pre-commit, black and isort in GitHub actions, but this will come later.

Closes #127

@sondrelg
Copy link
Member

What do you think about running codecov on both pull requests and pushes to master? The readme badge will display master coverage, but running it on pull-requests will post codecov reports in PRs.

Copy link
Member

@sondrelg sondrelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see suggestion about codecov in PRs

Co-authored-by: Sondre Lillebø Gundersen <sondrelg@live.no>
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #131 (d582cfd) into master (93bcb3f) will increase coverage by 0.21%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   82.69%   82.90%   +0.21%     
==========================================
  Files           7        8       +1     
  Lines         416      427      +11     
==========================================
+ Hits          344      354      +10     
- Misses         72       73       +1     
Impacted Files Coverage Δ
django_auth_adfs/middleware.py 90.90% <66.66%> (-9.10%) ⬇️
django_auth_adfs/backend.py 80.89% <100.00%> (+0.37%) ⬆️
django_auth_adfs/config.py 85.44% <100.00%> (+0.68%) ⬆️
django_auth_adfs/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f128ec...ce2f41a. Read the comment docs.

@JonasKs JonasKs mentioned this pull request Jan 19, 2021
5 tasks
@JonasKs JonasKs merged commit aac1291 into master Jan 19, 2021
@sondrelg sondrelg deleted the ci branch January 20, 2021 07:18
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
Removes travis and updates supported Django versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pipelines and remove tox
2 participants