Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast JtaTransactionManager to org.springframework.transaction.TransactionManager while calling TransactionManagerCustomizers.customize because method to be removed in Spring Boot 3.4.0 #172

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

graben
Copy link
Contributor

@graben graben commented Nov 24, 2024

Hi @geoand, can you please merge.
Thx Benjamin

…tionManager while calling TransactionManagerCustomizers.customize because method to be removed in Spring Boot 3.4.0
@geoand
Copy link
Member

geoand commented Nov 25, 2024

Hi,

What's the reason for doing this casting?

@graben
Copy link
Contributor Author

graben commented Nov 25, 2024

Spring Boot 3.2 has introduced an overloaded customize method TransactionManagerCustomizers for org.springframework.transaction.TransactionManager and marked for removal the old org.springframework.transaction.PlatformTransactionManager one. This method is now removed in Spring Boot 3.4 but compilation in narayana-spring-boot-starter 3.3.0 has been done against exactly this one causing Exceptions on startup.

@geoand
Copy link
Member

geoand commented Nov 25, 2024

Gotcha, thanks

@geoand geoand merged commit faf464d into snowdrop:main Nov 25, 2024
2 checks passed
@graben graben deleted the sb340fix branch November 25, 2024 06:36
@graben
Copy link
Contributor Author

graben commented Nov 25, 2024

Hi @jacobdotcosta,

can you please plan a 3.3.1 bugfix release?

Regards Benjamin

@jacobdotcosta
Copy link
Member

Yes, I'll do the release.

@jacobdotcosta
Copy link
Member

3.3.1.Beta1 has been released. @graben, could you please take a look at it.

@graben
Copy link
Contributor Author

graben commented Dec 4, 2024

Hi @jacobdotcosta, will do it this evening CET. Thanks Benjamin

@graben
Copy link
Contributor Author

graben commented Dec 4, 2024

@jacobdotcosta: Build and tested successfully. Go ahead with the release ;)

@jacobdotcosta
Copy link
Member

3.3.1 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants