add mutex lock to prevent race condition in exec() function (#834)

defer mutex unlock
snowflakedb · Jun 27, 2023 · ee57d93 · ee57d93
1 parent 663cccc
commit ee57d93
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/connection.go b/connection.go
@@ -73,6 +73,7 @@ type snowflakeConn struct {
 var (
 	queryIDPattern = `[\w\-_]+`
 	queryIDRegexp  = regexp.MustCompile(queryIDPattern)
+	errMutex = &sync.Mutex{}
 )
 
 func (sc *snowflakeConn) exec(
@@ -138,7 +139,10 @@ func (sc *snowflakeConn) exec(
 	}
 	logger.WithContext(ctx).Infof("Success: %v, Code: %v", data.Success, code)
 	if !data.Success {
-		return nil, (populateErrorFields(code, data)).exceptionTelemetry(sc)
+		errMutex.Lock()
+		defer errMutex.Unlock()
+		err = (populateErrorFields(code, data)).exceptionTelemetry(sc)
+		return nil, err
 	}
 
 	// handle PUT/GET commands