SNOW-848019: Add mutex lock to prevent race condition in populateErrorFields() #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defer mutex unlock
sfc-gh-ext-simba-lb
force-pushed
the
raceConditionInExecFunc
branch
from
eea6096
to
8574fc8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/491
An intermittent issue was reported where if a query failed while executing queries simultaneously, the wrong error message could be shown in the log.
The root cause is that during processing of the query response from the server inside the exec() function, there is a function populateErrorFields(). If two or more query responses are returned simultaneously and enter this function around the same time, it can cause a race condition where the error data is updated incorrectly. I am able to reproduce this about ~60% of the time without this change.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them