Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/snowplow web/1.0.0 #237

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Release/snowplow web/1.0.0 #237

merged 5 commits into from
Dec 5, 2023

Conversation

rlh1994
Copy link
Contributor

@rlh1994 rlh1994 commented Nov 27, 2023 •
edited
Loading

Description & motivation

This marks the 1.0.0 release of web. The changes are mostly cosmetic or a few small fixes, hence the single PR.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have raised a documentation PR if applicable (Link here if required)
  • Is your change a breaking change?

Release Only Checklist

  • I have updated the version number in all relevant places
  • I have updated the CHANGELOG.md

@rlh1994 rlh1994 force-pushed the release/snowplow-web/1.0.0 branch from d9ba745 to 694d4cf Compare November 27, 2023 11:52
@rlh1994 rlh1994 marked this pull request as ready for review November 28, 2023 15:49
@rlh1994 rlh1994 requested a review from emielver as a code owner November 28, 2023 15:49
emielver
emielver approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@emielver emielver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

README.md Show resolved Hide resolved
@rlh1994 rlh1994 force-pushed the release/snowplow-web/1.0.0 branch 2 times, most recently from d498e48 to 2ee5925 Compare November 29, 2023 16:51
georgewoodhead
georgewoodhead approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@georgewoodhead georgewoodhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@rlh1994 rlh1994 force-pushed the release/snowplow-web/1.0.0 branch from 2ee5925 to 0867137 Compare November 30, 2023 15:27
@emielver emielver force-pushed the release/snowplow-web/1.0.0 branch from a45f722 to 0867137 Compare December 1, 2023 11:16
@rlh1994 rlh1994 merged commit 177cdf6 into main Dec 5, 2023
4 checks passed
@rlh1994 rlh1994 deleted the release/snowplow-web/1.0.0 branch December 5, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgewoodhead georgewoodhead georgewoodhead approved these changes

@emielver emielver emielver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlh1994 @emielver @georgewoodhead