fix: occasional ETXTBSY on CLI runs (#4568)

* fix: bump tests to the signed version * fix: ensure that downloadExecutable doesn't resolve until file descriptor is closed
snyk · Apr 24, 2023 · cde8ca6 · cde8ca6
1 parent 3a45d54
commit cde8ca6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ts-binary-wrapper/src/common.ts b/ts-binary-wrapper/src/common.ts
@@ -260,7 +260,7 @@ export function downloadExecutable(
     // shasum events
     shasum.on('error', cleanupAfterError);
     // filestream events
-    fileStream.on('error', cleanupAfterError).on('finish', () => {
+    fileStream.on('error', cleanupAfterError).on('close', () => {
       const actualShasum = shasum.read();
       const debugMessage =
         'Shasums:\n- actual:   ' +

diff --git a/ts-binary-wrapper/test/acceptance/basic.spec.ts b/ts-binary-wrapper/test/acceptance/basic.spec.ts
@@ -8,7 +8,7 @@ jest.setTimeout(60 * 1000);
 
 describe('Basic acceptance test', () => {
   const envSetup = new TestEnvironmentSetup();
-  const cliVersionForTesting = '1.1080.0';
+  const cliVersionForTesting = '1.1143.0';
 
   beforeEach(async () => {
     process.env.SNYK_DISABLE_ANALYTICS = '1';