fix: occasional ETXTBSY on CLI runs #4568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Customers see ETXTBSY error when running CLI on Linux systems.
This PR ensures that we resolve download function only upon
close
event, when both stream has finished and file descriptor is closed.Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
I didn't manage to write tests in a reasonable time, as the current download implementation couples the download using
https
and the piping logic very tightly, making it very hard to test this scenario.What are the relevant tickets?
https://snyk.zendesk.com/agent/tickets/45267
Screenshots
Additional questions