Fix false positive on aws_route resources #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.7 #404 +/- ##
==========================================
+ Coverage 69.42% 69.46% +0.03%
==========================================
Files 281 281
Lines 6032 6039 +7
==========================================
+ Hits 4188 4195 +7
Misses 1491 1491
Partials 353 353
|
wbeuil
suggested changes
Apr 6, 2021
| @@ -63,11 +63,21 @@ func TestAwsRouteTableExpander_Execute(t *testing.T) { | |||
| }, | |||
| }, | |||
| { | |||
| "test route are expanded", | |||
| "test routes are expanded except when it already exist", | |||
There was a problem hiding this comment.
Can you, instead of changing the two current tests, create a new one. One test that won't expand already created routes in a default and a non-default route-table ?
sundowndev
force-pushed
the
fix/awsRouteExpander
branch
from
2c48b69
to
2077d3c
Compare
eliecharra
suggested changes
Apr 6, 2021
eliecharra
suggested changes
Apr 7, 2021
following code review feedback. pkg/middlewares/aws_route_table_expander.go
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AWS route table expander middleware was supposed to turn routes embeded in a route table into dedicated resources. But when a route is already a dedicated resource, the scan result shows it as a deleted resource.