Preempt PR3711(2) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ocity is below threshold Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…x/intersection-static-pass-judge
soblin
added a commit
that referenced
this pull request
May 22, 2023
* fix(intersection): use 0 offset peeking line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use braking distance Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * add pass_judge_wall_pose marker Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep detection if ego is between stopline and pass judge line and velocity is below threshold Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * modify condition Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use 0.0s for delay response time Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * right turn scenario passes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * find all stop line candidates at first in order Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use keep_detection_vel for staticPassJudgeLine Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
that referenced
this pull request
May 22, 2023
* fix(intersection): use 0 offset peeking line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use braking distance Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * add pass_judge_wall_pose marker Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep detection if ego is between stopline and pass judge line and velocity is below threshold Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * modify condition Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use 0.0s for delay response time Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * right turn scenario passes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * find all stop line candidates at first in order Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use keep_detection_vel for staticPassJudgeLine Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
that referenced
this pull request
May 22, 2023
This reverts commit 7fd41ab. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
that referenced
this pull request
May 23, 2023
…warefoundation#3765) * feat(intersection): disable peeking while collision is detected Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * preempt PR3711 (#11) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fixed !has_collision Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Preempt PR3711(2) (#13) * fix(intersection): use 0 offset peeking line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use braking distance Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * add pass_judge_wall_pose marker Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep detection if ego is between stopline and pass judge line and velocity is below threshold Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * modify condition Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use 0.0s for delay response time Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * right turn scenario passes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * find all stop line candidates at first in order Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use keep_detection_vel for staticPassJudgeLine Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * added COLLISION_DETECTED state Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * po Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Revert "Preempt PR3711(2) (#13)" This reverts commit 7fd41ab. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Revert "preempt PR3711 (#11)" This reverts commit a6d7fb6. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * call setSafe() regardless of occlusion_stop_required Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
that referenced
this pull request
May 23, 2023
…warefoundation#3765) * feat(intersection): disable peeking while collision is detected Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * preempt PR3711 (#11) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fixed !has_collision Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Preempt PR3711(2) (#13) * fix(intersection): use 0 offset peeking line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use braking distance Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * add pass_judge_wall_pose marker Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep detection if ego is between stopline and pass judge line and velocity is below threshold Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * modify condition Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use 0.0s for delay response time Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * right turn scenario passes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * find all stop line candidates at first in order Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use keep_detection_vel for staticPassJudgeLine Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * added COLLISION_DETECTED state Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * po Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Revert "Preempt PR3711(2) (#13)" This reverts commit 7fd41ab. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Revert "preempt PR3711 (#11)" This reverts commit a6d7fb6. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * call setSafe() regardless of occlusion_stop_required Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.