Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when passing WebSocket#send the second argument on Safari #375

Merged
merged 1 commit into from
Apr 6, 2015
Merged

Fix error when passing WebSocket#send the second argument on Safari #375

merged 1 commit into from
Apr 6, 2015

Conversation

nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Feb 18, 2015

WebSocket throws TypeError somehow on Safari/Midori as follows.

var ws = new WebSocket('http://localhost:3000');
ws.send('hi', undefined); // TypeError

This PR fixes the cause of socketio/socket.io#2000 .

@nkzawa nkzawa mentioned this pull request Feb 23, 2015
Closed
rauchg added a commit that referenced this pull request Apr 6, 2015
@rauchg
Merge pull request #375 from nkzawa/patch-9
87ee832 
Fix error when passing WebSocket#send the second argument on Safari
@rauchg rauchg merged commit 87ee832 into socketio:master Apr 6, 2015
@binarykitchen binarykitchen mentioned this pull request Jan 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkzawa @rauchg